Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTPS #10

Open
mathiasbynens opened this issue Mar 30, 2016 · 9 comments
Open

Enable HTTPS #10

mathiasbynens opened this issue Mar 30, 2016 · 9 comments

Comments

@mathiasbynens
Copy link

Making the website available over HTTPS would make it possible to add a service worker which could then be used to fix https://twitter.com/mbrochh/status/715135779136086017.

Since you seem to be using GitHub Pages, I guess enabling Cloudflare is the simplest way to set up HTTPS.

@janl
Copy link
Collaborator

janl commented Mar 30, 2016

I think this is simple enough to do in AppCache, as the previous site: b3b1dd7

That way we avoid more infra overhead at this point.

@mathiasbynens
Copy link
Author

AppCache is going away, though.

Adding a service worker is the only future-proof way of adding this functionality.

@janl
Copy link
Collaborator

janl commented Mar 30, 2016

sure, but right now, AppCache is the only thing that works and everywhere, and we don’t have to set up TLS for it, so I think it’s a clear win.

@janl
Copy link
Collaborator

janl commented Mar 30, 2016

implementation here: #12

@gr2m
Copy link
Collaborator

gr2m commented Mar 30, 2016

but let’s leave this open, would have https, so we can host Service Worker things ™️ Also appcache can still be used as fallback to ServiceWorker

@afknapping
Copy link

i am currently testing moving my own github-pages-site-with-custom-domain over to gitlab since they support SSL/TLS with custom domains via Let's Encrypt.

can let you know how that works out if interested (well, and if moving to gitlab is an option at all :)

@terichadbourne
Copy link
Contributor

@gr2m @kidfribble Wondering if we can circle back to enabling HTTPS both on offlinefirst.org and on the new offline.camp when we get that in place?

@gr2m
Copy link
Collaborator

gr2m commented Apr 25, 2019

That should fairly easy now: https://github.blog/2018-05-01-github-pages-custom-domains-https/

Important part:

If you are using A records, you must update your site's DNS records with new IP addresses. Please see our guide to setting up your custom domain with Pages and update any A records you might have set.

whoever owns offlinefirst.org has to update the A record, then we can set the switch to enforce SSL on the domain

@terichadbourne
Copy link
Contributor

terichadbourne commented Apr 25, 2019

The other issue that needs updating by the owner is this, which sounds related in the fix:

The page build completed successfully, but returned the following warning for the `gh-pages` branch:

The custom domain for your GitHub Pages site is pointed at an outdated IP address. You must update your site's DNS records if you'd like it to be available via your custom domain. For more information, see https://help.github.com/en/articles/using-a-custom-domain-with-github-pages.

For information on troubleshooting Jekyll see:

  https://help.github.com/articles/troubleshooting-jekyll-builds

If you have any questions you can contact us by replying to this email.

@gr2m told me earlier when I showed him that:
"not sure who owns offlienfirst.org right now, looks like it is on IWANTMYNAME.NET? The DNS entry needs to be updated to point on a new IP"

@kidfribble Have you already figured out who has it registered right now? @janl perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants