-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable HTTPS #10
Comments
I think this is simple enough to do in AppCache, as the previous site: b3b1dd7 That way we avoid more infra overhead at this point. |
AppCache is going away, though.
Adding a service worker is the only future-proof way of adding this functionality. |
sure, but right now, AppCache is the only thing that works and everywhere, and we don’t have to set up TLS for it, so I think it’s a clear win. |
implementation here: #12 |
but let’s leave this open, would have https, so we can host Service Worker things ™️ Also appcache can still be used as fallback to ServiceWorker |
i am currently testing moving my own github-pages-site-with-custom-domain over to gitlab since they support SSL/TLS with custom domains via Let's Encrypt. can let you know how that works out if interested (well, and if moving to gitlab is an option at all :) |
@gr2m @kidfribble Wondering if we can circle back to enabling HTTPS both on offlinefirst.org and on the new offline.camp when we get that in place? |
That should fairly easy now: https://github.blog/2018-05-01-github-pages-custom-domains-https/ Important part:
whoever owns offlinefirst.org has to update the A record, then we can set the switch to enforce SSL on the domain |
The other issue that needs updating by the owner is this, which sounds related in the fix:
@gr2m told me earlier when I showed him that: @kidfribble Have you already figured out who has it registered right now? @janl perhaps? |
Making the website available over HTTPS would make it possible to add a service worker which could then be used to fix https://twitter.com/mbrochh/status/715135779136086017.
Since you seem to be using GitHub Pages, I guess enabling Cloudflare is the simplest way to set up HTTPS.
The text was updated successfully, but these errors were encountered: