-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Appearance Ontology from CityRDF #15
Comments
Total usages of Core package classes mentioned in Appearance package:
Either Core classes are mentioned in triples like ?s rdfs:subClassOf core:Class Or in triples like ?s rdfs:subClassOf [ a owl:Restriction ;
owl:allValuesFrom core:MimeTypeValue ;
owl:onProperty ?prop ],
[ a owl:Restriction ;
owl:maxQualifiedCardinality "1"^^xsd:nonNegativeInteger ;
owl:onClass core:MimeTypeValue ;
owl:onProperty ?prop ],
... I can create "isolated of Core" Appearance package, and rebalance the rest of packages (=add necessary axioms to the other relevant packages) with the sequence of steps:
If the whole CityRDF ontology is put to a knowledge graph such isolation does not make sense, since all the triples are in the same named graph. core:MimeTypeValue owl:equivalentClass app:MimeTypeValue . into Core package ontology. |
Generally this is the line of thinking that I also had in mind. That what is in core and not used by any other modules can be in CityRDF appearance module. It would be the first step in refactoring. I have noticed that inheriting from core:AbstractAppearance reduces to inheriting form core:AbstractFeature, which is a subclass of iso19109:AnyFeature. CityRDF Appearance module can still keep those AbstractClasses, but the new Appearance ontology can be done without them. Further refactoring along those lines could be done following way: Appearance Ontology:
CityRDF Appearance module:
|
At the moment the Appearance ontology is part of CityRDF. Its IRI is https://www.opengis.net/ont/citygml/appearance
It also imports https://www.opengis.net/ont/citygml/common and https://www.opengis.net/ont/citygml/core
Following classes from Core are used in axioms of Appearance
core:AbstractAppearance
core:TransformationMatrix2x2
core:TransformationMatrix3x4
core:DoubleList
core:DoubleBetween0and1
core:MimeTypeValue
core:AbstractFeature
There is also proposal for texture support in GeoSPARQL opengeospatial/ogc-geosparql#611 (comment)
If Appearance ontology was separated from CityRDF, it would be possible to apply textures to geospatial objects from other domains outside of cities independently. GeoSPARQL could still be as a query language wherever textures are applied and without dependency on cities specific clases. This new Appearance ontology could be also imported by the CityRDF Appearance module.
@nataschake @avillar let's investigate how to proceed with this separation on our next meeting.
@rob-metalinkage please let us know, if you see anything in this that could be not very well aligned with CityRDF.
The text was updated successfully, but these errors were encountered: