Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update storybook aws deployment #206

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix: update storybook aws deployment #206

merged 2 commits into from
Jun 21, 2024

Conversation

hamza14khan
Copy link
Contributor

  • Check process.env.DS_ENV on viteFinal.
  • Use /ogcio-ds/ for Github pages else, default path /.

TODO: testing required.

@hamza14khan hamza14khan requested a review from ianlnf June 20, 2024 16:19
@hamza14khan hamza14khan self-assigned this Jun 20, 2024
@ianlnf ianlnf changed the title fix: update environment variable usage for Storybook AWS deployment fix: update storybook aws deployment Jun 21, 2024
@ianlnf ianlnf marked this pull request as ready for review June 21, 2024 14:52
@ianlnf ianlnf merged commit 0df5a9f into main Jun 21, 2024
1 check passed
@ianlnf ianlnf deleted the fix/aws-storybook branch June 21, 2024 14:53
@seravat
Copy link

seravat commented Jun 21, 2024

@ianlnf Hello, I am Joao from RedHat, did a project 1 year ago for ogcio.

I keep receiving updates from the OGCIO repos, can you please remove me from the organization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants