Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Unnecessary Browser Pop-up on Patient Registration Form in Public Portal Post Phone Number Login #10246

Closed
nihal467 opened this issue Jan 28, 2025 · 5 comments · Fixed by #10251
Assignees

Comments

@nihal467
Copy link
Member

Describe the bug

After logging in with a phone number and creating a new patient on the public page, an unnecessary browser warning is displayed. This warning should only appear if the user attempts to leave the form without completing it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the /login page
  2. Enter a valid phone number; the static OTP is 45612
  3. Select any random facility with a hospital (Ernakulam District, MNHS facility)
  4. Book an appointment for a user
  5. Create a new patient
  6. Observe the error

Expected behavior

The browser pop-up should only appear if the user tries to navigate away after partially filling out the form.

Screenshots

Image

@nihal467 nihal467 changed the title Disable Unnecessary Browser Pop-up on Patient Registration Form in Public Portal After Phone Number Login Disable Unnecessary Browser Pop-up on Patient Registration Form in Public Portal Post Phone Number Login Jan 28, 2025
@AdityaJ2305
Copy link
Contributor

AdityaJ2305 commented Jan 28, 2025

Image Image

@nihal467 , unable to reproduce

@rajku-dev
Copy link
Contributor

rajku-dev commented Jan 28, 2025

I have figured this out, can i work on it @nihal467

@rajku-dev
Copy link
Contributor

rajku-dev commented Jan 28, 2025

@nihal467 , unable to reproduce

You need to register the patient first after filling all fields

@AdityaJ2305
Copy link
Contributor

Hey @nihal467 , I would like to work on this issue, Successfully counter the error and solved it

@nihal467
Copy link
Member Author

@rajku-dev don't push PR without getting them assigned, since @AdityaJ2305 is already working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants