Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close button to the notification #9657

Closed
tellmeY18 opened this issue Jan 2, 2025 · 3 comments · Fixed by #9675
Closed

Add close button to the notification #9657

tellmeY18 opened this issue Jan 2, 2025 · 3 comments · Fixed by #9675
Assignees
Labels
needs-triage question Further information is requested

Comments

@tellmeY18
Copy link
Member

Image

Description

The current UI implementation does not provide a way for users to close or dismiss the notification popups that appear in the application. This can be frustrating for users, as they may want to clear the notifications without having to wait for them to automatically disappear.

Expected Behavior

Users should be able to manually close or dismiss the notification popups by clicking on a close button, an "X" icon, or some other intuitive UI element.

Actual Behavior

When a notification popup appears, there is no way for the user to close it. The popup will automatically disappear after a certain amount of time, but the user cannot manually dismiss it.

Steps to Reproduce

  1. Navigate to the care.ohc.network and login.
  2. Perform an action that triggers a notification popup (check patients).
  3. Observe that the notification popup appears but cannot be closed by the user.

Proposed Solution

Implement a close button, an "X" icon, or some other intuitive UI element that allows users to manually dismiss the notification popups when they appear. This will give users more control over the notification system and improve the overall user experience.

Acceptance Criteria

  • Users can close or dismiss the notification popups by clicking on a close button, an "X" icon, or some other intuitive UI element.
  • Closing the notification popup should remove it from the screen immediately, without requiring the user to wait for it to automatically disappear.
  • The close/dismiss functionality should be consistent across all notification popups in the application.
@Rishith25
Copy link
Contributor

Rishith25 commented Jan 2, 2025

@tellmeY18 @Jacobjeevan I would like to work on this

@AdityaJ2305
Copy link
Contributor

AdityaJ2305 commented Jan 2, 2025

Hey @Rishith25 , I have fixed the issue can I push the pr for it ?

@Rishith25
Copy link
Contributor

Rishith25 commented Jan 2, 2025

Hey @Rishith25 , I have fixed the issue can I push the pr for it

Hey @AdityaJ2305 I would like to work on it could you please work on any other issues.
I will raise the PR

@github-actions github-actions bot added needs-triage question Further information is requested labels Jan 2, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Care Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage question Further information is requested
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants