Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter is not searching for "Remdesivir, Tocilizumab etc." even Medicine is selected tab #228

Open
technoknol opened this issue Apr 30, 2021 · 7 comments

Comments

@technoknol
Copy link

Is your feature request related to a problem? Please describe.
If I want to search for Remdesivir or Tocilizumab I'm unable to get it. Right now twitter query is searching for verified Oxygen, Ventilators and Bed even when I'm on medicine tab.

Describe the solution you'd like
Medicine and All tab should search for Remdesivir or Tocilizumab or any other critical relative medicine.

Describe alternatives you've considered
NA

Additional context
NA

@technoknol technoknol changed the title Twitter is not searching for "Remdesivir or Tocilizumab" even Medicine is selected tab Twitter is not searching for "Remdesivir, Tocilizumab etc." even Medicine is selected tab Apr 30, 2021
@minkeshj
Copy link

minkeshj commented May 3, 2021

I believe this issue has been resolved already. We can close it.
image

@viksit
Copy link
Contributor

viksit commented May 3, 2021

No this is not solved.

The way to solve this is,

  • map medicines to a list of medicines [medrol, dolo, ...]
  • call the Twitter search api with a new parameter called resource_type_detail=medicine&resource_meta=dolo,medrol.. (comma separated string of the above list)
  • Ping @brainless or @apoorvsingal in the search channel on slack to have them integrate this in the Twitter search backend

@n3jain
Copy link

n3jain commented May 4, 2021

@viksit It looks like the covidConnect API for twitter search only supports two kinds of resource_type filtering 1. Supply 2. Demand. Also, the search string is constructed only from the location, doesn't take into the resource type or district. In order to make the twitter search appropriate based on the resource type and district, the updates need to be done for the covidconnect API. Could you please point to where the covid connect repository is, so that I can expand the feature set for that API?

@brainless
Copy link

@n3jain let me have a look at this today. @apoorvsingal and myself are in the covidconnect repo. If you have time right now then please feel free to make the changes, I can review the PR. The repo is at https://github.com/viksit/covidconnect

@minkesh
Copy link

minkesh commented May 5, 2021

@brainless @viksit I have raised the PR to integrate the changes done by @n3jain to support searching of medicines via covidconnect api. Now we have capability to search for required resources on twitter (previously it was a fixed hardcoded query).

@minkeshj
Copy link

minkeshj commented May 5, 2021

Please review #268

@viksit
Copy link
Contributor

viksit commented May 10, 2021

Deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants