Make setting the LESS environment var work better with git

[nicvagn]

If you
export LESS=-FRX

git does not pipe output (ie: git branch) through less unless it is more than a page.

I do not know where LESS is set as an environment var, but the setting as it is interferes wit my git workflow

[akinomyoga]

If you want to override the environment variable, you can write the setting after source "$OSH"/oh-my-bash.sh in ~/.bashrc.

[akinomyoga]

That is a fair point. What is the reason fror setting the LESS environment variable?

I'm not sure because I just took over the maintenance so do not know every detail of the background of each setting.

If it is just because the oh-my-zsh does it, why do they do it?

If it is just imported from Oh My Zsh, I think we can just look at what the upstream Oh My Zsh does with it. If they already changed the default value to be the one that works better with git, we can just follow it after checking the relevant discussion in the upstream. Or, if they removed it, we can remove it similarly.

I can not check every tool and config.

Yes, it's impossible to make a perfect survey. However, we should make a certain level of effort before making a possibly breaking change. At least, I cannot merge a breaking change without any investigations or considerations about possible impact.

I just wanted to bring it up. I do not even know where to start on said investigation.

I'd appreciate it if you could check how Oh My Zsh handles it. Maybe OMZ doesn't set the LESS environment, or OMZ sets a certain value. If it is different from the setup in OMB, we'd like to also check the change history in OMZ.

[nicvagn]

https://github.com/ohmyzsh/ohmyzsh/blob/fd01fd66ce27c669e5ffaea94460a37423d1e134/lib/misc.zsh#L22

here is where it is set.

From the man pages:

 R  -    Repaint the screen, discarding any buffered input.  That
           is, reload the current file.  Useful if the file is
           changing while it is being viewed.

so oh-my-zsh set's it, I will ask why

[akinomyoga]

https://github.com/ohmyzsh/ohmyzsh/blob/fd01fd66ce27c669e5ffaea94460a37423d1e134/lib/misc.zsh#L22

here is where it is set.

Thank you for checking! The setup of OMZ seems to be the same as ours.

so oh-my-zsh set's it, I will ask why

Yeah, I assume they know about it better. Let's see what they think about it.

[nicvagn]

Good call. No response yet.

[nicvagn]

In my own case, with some further use I find that export LESS=-FX is more usable. The R flag causes the screen to redraw, witch I do not personally want.

I think the native configuration messing with a ubiquitous command like git is a bug.
:. it is more sane to leave it as it is, rather than introducing a bug by setting it. I will have to see what the justification was though.