-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery and Powerline-multiline conflict #193
Comments
How is the battery plugin enabled? |
Same issue on my side, clean installation with powerline-multiline and battery plugin enabled |
No one seems to describe what is the issue explicitly, but you are talking about the extra line between the line showing information (times, batteries, etc.) and the line where the user command will be input, right? |
Yup, that extra blue line was the problem. But at this point this issue is so old that I do not use oh-my-bash, and my machine OS changed multiple times, therefore I cannot share a MWE, but I had some similar issues with starship as well, tho rarely, therefore I think it's a general problem with all these codes, If I had that config available I would have been able to check it on different terminals, but I don't think it only happened on yakuake, but I don't know, maybe it was a font problem or a bug fixed by now! update: I guess the problem is emoji, use nerd font with a mono font and use space after nerd font glyphs and the problem would not sustain with a 99% chance |
Thank you for the information!
OK, so you have been using yakuake at that time? I have now tried
Yeah, probably it is related to the calculation of the width of each character. Some terminals uses the font metrics to determine the character width, but the basic agreement between most terminals and terminal applications are to use the system's
The original problem might be solved in the latest version of yakuake, but @KrappRamiro seems to have experienced the same now, though I'm not sure if @KrappRamiro uses the same terminal. Hi, @KrappRamiro, what is your terminal and the font used there? |
I now tried I'm not sure if this is something that can be fixed at the oh-my-bash side but will later take a look at it. |
I think the best we can do is to pinpoint the problem, because foremost, it's not "just omb" problem, then we can at least warn users in README about such problems happening again. But first we clarify its fonts? Terminals? Even I am not really sure at this point |
Hi, sorry for slow replying, my terminal is gnome-terminal, and the font is SauceCodePro Nerd Font. But for some weird reason, the bug its not happening anymore. I dont know why, maybe its because the emoji isnt appearing, so its no longer pushing the blue square out of line? |
Thank you for the information! So you haven't changed the font since you last reported it? It is interesting that even with the same font, the problem may happen or not happen. Maybe there are even other factors. |
I haven't changed the font, yeah. |
Oh, I see. That makes sense. Thank you for the information. Let me think about possible solutions. I think the powerline theme doesn't have the ability to correctly calculate the width of strings that contain double-width characters. To solve this, we need to either
Solution B is ideal, but it is hard to implement in the shell script. My personal project contains such an implementation in a shell script, but I don't think it is a good idea to port it here because it has thousands of lines of code.
Edit: I found |
yeah, i focused on this rather than tput-like functionality. i don't think i have anything to help you immediately, but keep me in the loop! |
Thank you for your reply! |
I fixed it by replacing the icon in Another fix is to add a zero-width character afterwards, so that the character count is correct no matter how it is done. |
when battery plugin is enabled this happen
The text was updated successfully, but these errors were encountered: