Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally set object ACL #54

Closed
hkupty opened this issue Sep 25, 2017 · 3 comments
Closed

Optionally set object ACL #54

hkupty opened this issue Sep 25, 2017 · 3 comments

Comments

@hkupty
Copy link
Contributor

hkupty commented Sep 25, 2017 •
edited
Loading

Hi!
Currently, sbt-s3-resolver sets the default ACL value as PublicRead. While that can easily be changed to Private, I'd still need to have a s3:PutObjectAcl permission when running.

What I'd like is to optionally set the ACL value (such as Some(CannedAccessControlList.PublicRead)) and, if None, don't supply an ACL value at all, using the bucket default instead.

I understand that this would also affect ivy-s3-resolver, but if you agree, I can come up with PRs for both projects.

Cheers,
Henry Kupty
@hkupty hkupty mentioned this issue Sep 25, 2017
Merged
@laughedelic
Copy link
Contributor

laughedelic commented Sep 25, 2017 •
edited
Loading

Hey @hkupty! Sounds like a good idea 👍 Pull-requests are always welcome.

@hkupty hkupty mentioned this issue Sep 25, 2017
Merged
@hkupty
Copy link
Contributor Author

hkupty commented Sep 26, 2017

I think this can be closed now. Thank you very much for the plugin and the supportiveness!
Cheers

@hkupty hkupty closed this as completed Sep 26, 2017
@laughedelic
Copy link
Contributor

It's my pleasure 😊 Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laughedelic @hkupty