Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/swift: tweak retry config #475

Closed
buchanae opened this issue Jan 31, 2018 · 1 comment · Fixed by #552
Closed

storage/swift: tweak retry config #475

buchanae opened this issue Jan 31, 2018 · 1 comment · Fixed by #552

Comments

@buchanae
Copy link
Contributor

We're getting frequent failures from our swift cluster (503 unavailable) and the retrier isn't doing enough. In it's current default configuration, it will only retry for a couple seconds.

Just how long to retry is an open question, but I'd say we should err on the side of retrying for too long, rather than too briefly. These are large files being uploaded, created as the result of processes that potentially take multiple days, so it's worth retrying for hours even.

More technically, we could drop the MaxRetries in favor of MaxElapsedTime, which I think is a better configuration. It's more difficult to calculate the max amount of time you're retrying from a count number with exponential backoff involved.

@buchanae
Copy link
Contributor Author

Somewhat related: it'd be nice to know exactly how the underlying ncw/swift library handles 503 errors. Does one 503 error mean the entire file needs to be retried? Can it have better handling of segment uploads to the whole upload progress isn't lost?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant