Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Drop Vision Name and PascalCase Classes #89

Closed
oke-aditya opened this issue Dec 12, 2020 · 2 comments · Fixed by #92
Closed

[RFC] Drop Vision Name and PascalCase Classes #89

oke-aditya opened this issue Dec 12, 2020 · 2 comments · Fixed by #92
Labels
enhancement New feature or request feature A new feature request users Need Feedback from users

Comments

@oke-aditya
Copy link
Owner

🚀 Feature

Drop the names as VisionFasterRCNN, VisionCNN, let's call it CNN, Faster RCNN

Motivation

Why have the abstraction for Vision ...

Pitch

Replace these all names, and remove vision.
It's a breaking change and hence delayed to 0.2.0

Alternatives

Let stuff stay as it is. 📦
@oke-aditya oke-aditya added enhancement New feature or request feature A new feature request users Need Feedback from users labels Dec 12, 2020
@hassiahk
Copy link
Contributor

I don't mind keeping it like this.

@oke-aditya oke-aditya changed the title [RFC] Drop Vision Name [RFC] Drop Vision Name and PascalCase Classes Dec 13, 2020
@oke-aditya
Copy link
Owner Author

oke-aditya commented Dec 13, 2020 •
edited
Loading

Also we should PascalCase the classes as a standard Python convention all over the library.

Let's do this in release 0.2. Release 0.2 will have better and stable API.

@oke-aditya oke-aditya pinned this issue Dec 13, 2020
@oke-aditya oke-aditya mentioned this issue Dec 14, 2020
Merged
@oke-aditya oke-aditya unpinned this issue Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature A new feature request users Need Feedback from users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renames to Follow Conventions
2 participants
@hassiahk @oke-aditya