fix: revert to esbuild@0.13.3, to fix perf regression with v0.13.4

okikio · Oct 7, 2021 · 59b789f · 59b789f
1 parent b31fa8d
commit 59b789f
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -40,7 +40,7 @@
         "browser-builtins": "^3.3.1",
         "buffer": "^6.0.3",
         "countapi-js": "^1.0.2",
-        "esbuild-wasm": "^0.13.4",
+        "esbuild-wasm": "^0.13.3",
         "events": "^3.3.0",
         "highlight.js": "^11.2.0",
         "memfs": "^3.3.0",
@@ -64,7 +64,7 @@
         "browser-sync": "^2.27.5",
         "commitizen": "^4.2.4",
         "del": "^6.0.0",
-        "esbuild": "^0.13.4",
+        "esbuild": "^0.13.3",
         "esbuild-plugin-solid": "^0.4.0",
         "fibers": "^5.0.0",
         "gulp": "^4.0.2",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/assets/_headers b/src/assets/_headers
@@ -15,7 +15,7 @@
   Link: <https://fonts.gstatic.com/s/materialiconsround/v62/LDItaoyNOAY6Uewc665JcIzCKsKc_M9flwmP.woff2>; rel=preload; as=font; type=font/woff2; crossorigin=anonymous
   Link: </css/app.min.css>; rel=preload; as=style
   Link: </js/theme.min.js>; rel=modulepreload
-  Link: <https://cdn.polyfill.io/v3/polyfill.min.js?features=requestIdleCallback>; rel=preload; as=script
+  # Link: <https://cdn.polyfill.io/v3/polyfill.min.js?features=requestIdleCallback>; rel=preload; as=script
   Link: </js/critical.min.js>; rel=modulepreload
 
 /

diff --git a/src/ts/critical.ts b/src/ts/critical.ts
@@ -176,6 +176,6 @@ window.addEventListener("load", () => {
         });
 
         // window.addEventListener("load", () => { });
-        wb.register();
+        // wb.register();
     }
 })();
diff --git a/src/ts/index.ts b/src/ts/index.ts
@@ -62,9 +62,8 @@ BundleEvents.on({
             let share = searchParams.get("share");
             let bundle = searchParams.get("bundle");
             if (query || share || plaintext) {
-                fileSizeEl.textContent = `Wait...`;
-
                 if (bundle != null) {
+                    fileSizeEl.textContent = `Wait...`;
                     BundleEvents.emit("bundle");
                 }
             }

diff --git a/src/ts/modules/monaco.ts b/src/ts/modules/monaco.ts
@@ -104,7 +104,7 @@ const format = (code: string) => {
  * ```
  * where the brackets represent seperate packages
  */
-export const parseTreeshakeExports = (str: string) =>
+export const parseTreeshakeExports = (str: string) => 
     (str ?? "").split(/\],/).map((str) => str.replace(/\[|\]/g, ""));
 
 // Inspired by https://github.com/solidjs/solid-playground