Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Velocity] Disconnected when chatting with 1.19.1 client #92

Open
Siroshun09 opened this issue Jul 31, 2022 · 0 comments
Open

[Velocity] Disconnected when chatting with 1.19.1 client #92

Siroshun09 opened this issue Jul 31, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Siroshun09
Copy link
Member

Siroshun09 commented Jul 31, 2022

Velocity no longer allows chat events to be canceled, so the player will be disconnected when chatting from a 1.19.1 client.

The message can be sent to Discord. This issue will have to wait for Velocity to develop a new API.

Cause: https://github.com/PaperMC/Velocity/blob/c57fb489f3cc664fe05cdbdbb24fdca1347ef446/proxy/src/main/java/com/velocitypowered/proxy/connection/client/ClientPlaySessionHandler.java#L199-L204

Logs

[10:56:13] [Velocity Async Event Executor - #2/INFO]: <Siroshun09> test
[10:56:13] [Netty NIO Worker #0/FATAL]: A plugin tried to cancel a signed chat message. This is no longer possible in 1.19.1 and newer. Disconnecting player Siroshun09
[10:56:13] [Netty NIO Worker #0/INFO]: [connected player] Siroshun09 (/127.0.0.1:54895) has disconnected: A proxy plugin caused an illegal protocol state. Contact your network administrator.

Other Information

It is possible to chat normaly in Paper and Waterfall.

This problem is confirmed by the latest commit on the dependencies/jda-5 branch, but I expect the same thing to happen in 2.5. I don't know what Velocity will do about it, but I will release it as 2.6 if I can fix this.

@Siroshun09 Siroshun09 added the bug Something isn't working label Jul 31, 2022
@Siroshun09 Siroshun09 self-assigned this Jul 31, 2022
@Siroshun09 Siroshun09 changed the title Cannot chat from 1.19.1 client on Velocity [Velocity] Disconnected when chatting with 1.19.1 client Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant