Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Under cygwin no tasks are created #1025

Closed
tkalmar opened this issue Oct 7, 2021 · 2 comments · Fixed by #1026
Closed

Under cygwin no tasks are created #1025

tkalmar opened this issue Oct 7, 2021 · 2 comments · Fixed by #1026
Labels
released on @beta released

Comments

@tkalmar
Copy link
Contributor

tkalmar commented Oct 7, 2021

Description

No staged files match any configured task.

Culprit is the determination of the git repo dir
under cygwin git rev-parse --show-toplevel leads to /cygrdrive/c/home/user/project
process.cwd() leads to C:/cygdrive/c/home/user/project

So all changed files are finaly resolved to something like `......\cygdrive\c\home\user\project\changed.js

and are filtered as relative paths

Steps to reproduce

npx lint-staged under a cygwin environment

Debug Logs

Environment

  • OS: Windows 10
  • Node.js: v14.17.6
  • lint-staged: 11.1.1
@tkalmar tkalmar mentioned this issue Oct 7, 2021
Merged
iiroj pushed a commit that referenced this issue Oct 9, 2021
@tkalmar
fix: detect git repo root correctly on cygwin (#1026)
f291824 
* Fix  #1025 using git rev-parse to get the relative path inside git repo

Co-authored-by: Thomas Kalmar <KalmarT@t-systems.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

🎉 This issue has been resolved in version 11.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 11.3.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sync-by-unito sync-by-unito bot mentioned this issue Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @beta released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1025 using git rev-parse to get the relative path inside git repo
1 participant
@tkalmar