Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing entry file #283

Merged
merged 1 commit into from
Sep 15, 2017
Merged

fix: missing entry file #283

merged 1 commit into from
Sep 15, 2017

Conversation

luftywiranda13
Copy link
Collaborator

@luftywiranda13 luftywiranda13 commented Sep 15, 2017

@okonet @sudo-suhas

This is a super important bugfix.. We accidentally introduced a breaking change!
I missed this in #250 😭

See https://travis-ci.org/luftywiranda13/generator-node-oss/jobs/275875611#L450

Closes #284

@codecov
Copy link

codecov bot commented Sep 15, 2017

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          10       10           
  Lines         168      168           
  Branches       25       25           
=======================================
  Hits          154      154           
  Misses         13       13           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30fa594...c265fe1. Read the comment docs.

@luftywiranda13
Copy link
Collaborator Author

screen shot 2017-09-15 at 20 12 10

@luftywiranda13 luftywiranda13 merged commit e17ba5f into master Sep 15, 2017
@luftywiranda13 luftywiranda13 deleted the luftywiranda13-patch-1 branch September 15, 2017 13:28
@sudo-suhas
Copy link
Collaborator

What would we need to do so that this catches such issues - https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-unpublished-require.md

@luftywiranda13
Copy link
Collaborator Author

That rule has been activated in this project but it only affects src

what's your take on this?

@okonet
Copy link
Collaborator

okonet commented Sep 15, 2017

That rule has been activated in this project but it only affects src

I'm not sure about that. Is it in the recommended config?

@luftywiranda13
Copy link
Collaborator Author

yeah, it's in the recommended config

@okonet
Copy link
Collaborator

okonet commented Sep 15, 2017

So can we change the rule to catch that in future?

@sudo-suhas
Copy link
Collaborator

sudo-suhas commented Sep 15, 2017

index.js might be it's achilles heel. What I mean to say is, this rule checks for imports right.. Who is importing it other than tests? Will it error in test files? Please do check.

@luftywiranda13
Copy link
Collaborator Author

luftywiranda13 commented Sep 15, 2017

@okonet
Copy link
Collaborator

okonet commented Sep 15, 2017

@luftywiranda13 could you please do what's needed and file a PR?

@luftywiranda13
Copy link
Collaborator Author

@okonet sure, I'll do it in the morning 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

v4.2.0 can't be installed because index.js is missing
3 participants