-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing entry file #283
Conversation
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 10 10
Lines 168 168
Branches 25 25
=======================================
Hits 154 154
Misses 13 13
Partials 1 1 Continue to review full report at Codecov.
|
What would we need to do so that this catches such issues - https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-unpublished-require.md |
That rule has been activated in this project but it only affects what's your take on this? |
I'm not sure about that. Is it in the recommended config? |
yeah, it's in the recommended config |
So can we change the rule to catch that in future? |
|
Move Currently it's used here.. Suggestions? |
@luftywiranda13 could you please do what's needed and file a PR? |
@okonet sure, I'll do it in the morning 👍 |
@okonet @sudo-suhas
This is a super important bugfix.. We accidentally introduced a breaking change!
I missed this in #250 😭
See https://travis-ci.org/luftywiranda13/generator-node-oss/jobs/275875611#L450
Closes #284