perf: Switch from minimatch to micromatch #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Since micromatch supports multiple patterns for filtering, filter staged files in a single pass for match and ignore patterns. BREAKING CHANGE: The following `minimatch` options are not supported in `micromatch`: - `nocomment`: https://github.com/isaacs/minimatch#nocomment - `flipnegate`: https://github.com/isaacs/minimatch#flipnegate
sudo-suhas
force-pushed
the
perf/micromatch
branch
from
aa0898c
to
391b895
Compare
Codecov Report
@@ Coverage Diff @@
## next #388 +/- ##
==========================================
- Coverage 98.13% 98.11% -0.03%
==========================================
Files 10 10
Lines 215 212 -3
Branches 26 23 -3
==========================================
- Hits 211 208 -3
Misses 4 4
Continue to review full report at Codecov.
|
okonet
approved these changes
Jan 31, 2018
sudo-suhas
added a commit
that referenced
this pull request
Feb 17, 2018
Since micromatch supports multiple patterns for filtering, filter staged files in a single pass for match and ignore patterns. BREAKING CHANGE: The following `minimatch` options are not supported in `micromatch`: - `nocomment`: https://github.com/isaacs/minimatch#nocomment - `flipnegate`: https://github.com/isaacs/minimatch#flipnegate
sudo-suhas
added a commit
that referenced
this pull request
Feb 17, 2018
Since micromatch supports multiple patterns for filtering, filter staged files in a single pass for match and ignore patterns. BREAKING CHANGE: The following `minimatch` options are not supported in `micromatch`: - `nocomment`: https://github.com/isaacs/minimatch#nocomment - `flipnegate`: https://github.com/isaacs/minimatch#flipnegate
sudo-suhas
added a commit
that referenced
this pull request
Feb 21, 2018
Since micromatch supports multiple patterns for filtering, filter staged files in a single pass for match and ignore patterns. BREAKING CHANGE: The following `minimatch` options are not supported in `micromatch`: - `nocomment`: https://github.com/isaacs/minimatch#nocomment - `flipnegate`: https://github.com/isaacs/minimatch#flipnegate
This was referenced Feb 21, 2018
This was referenced Mar 15, 2018
This was referenced Apr 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
micromatchsupports multiple filter patterns, this does the changes to filter staged files in a single pass for match and ignore patterns.The following
minimatchoptions are not supported inmicromatch:nocomment: isaacs/minimatch#nocommentflipnegate: isaacs/minimatch#flipnegateSo the change needs to go in a major release. The
nextbranch, which this targets for the merge, will include multiple breaking changes and these will be released in a single major release.