Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Drop support for Node.js 4 #399

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Conversation

sudo-suhas
Copy link
Collaborator

This sets the minimum required Node.js version to >=6 and does the relevant config, code and docs update.

Code Changelog

  • Change Node.js requirement in engines.node to >=6. Use please-upgrade-node to give helpful error message on older versions.
  • Remove node 4 from list of Node.js versions to test on CI. Also remove --ignore-engines flag for yarn install, not required with node 6.
  • Add note to readme for Node.js version requirement.
  • Target node 6 for babel-preset-env (relevant only for tests).
  • Add eslint rule for prefer-destructuring, do relevant code changes.
  • Use default argument for logger passed to src/index.js

Closes #372.

@sudo-suhas sudo-suhas mentioned this pull request Feb 17, 2018
@codecov
Copy link

codecov bot commented Feb 17, 2018

Codecov Report

Merging #399 into next will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #399      +/-   ##
==========================================
- Coverage   98.22%   98.16%   -0.06%     
==========================================
  Files          11       11              
  Lines         225      218       -7     
  Branches       24       24              
==========================================
- Hits          221      214       -7     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 88.88% <100%> (-0.59%) ⬇️
src/runAll.js 100% <100%> (ø) ⬆️
src/checkPkgScripts.js 100% <100%> (ø) ⬆️
src/findBin.js 100% <100%> (ø) ⬆️
src/getConfig.js 100% <100%> (ø) ⬆️
src/runScript.js 100% <100%> (ø) ⬆️
src/generateTasks.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27fc4c...9c9f7a8. Read the comment docs.

- Change Node.js requirement in `engines.node` to `>=6`. Use
  `please-upgrade-node` to give helpful error message on older versions.
- Remove node 4 from list of Node.js versions to test on CI. Also remove
  `--ignore-engines` flag for `yarn install`, not required with node 6.
- Add note to readme for Node.js version requirement.
- Target node 6 for `babel-preset-env` (relevant only for tests).
- Add eslint rule for `prefer-destructuring`, do relevant code changes.
- Use default argument for `logger` passed to `src/index.js`

BREAKING CHANGE: Requires Node.js v6 or later.
@sudo-suhas sudo-suhas merged commit b739fe3 into next Feb 17, 2018
@sudo-suhas sudo-suhas deleted the refactor/drop-node-4-support branch February 17, 2018 09:11
sudo-suhas added a commit that referenced this pull request Feb 19, 2018
- Change Node.js requirement in `engines.node` to `>=6`. Use
  `please-upgrade-node` to give helpful error message on older versions.
- Remove node 4 from list of Node.js versions to test on CI. Also remove
  `--ignore-engines` flag for `yarn install`, not required with node 6.
- Add note to readme for Node.js version requirement.
- Target node 6 for `babel-preset-env` (relevant only for tests).
- Add eslint rule for `prefer-destructuring`, do relevant code changes.
- Use default argument for `logger` passed to `src/index.js`

BREAKING CHANGE: Requires Node.js v6 or later.
sudo-suhas added a commit that referenced this pull request Feb 21, 2018
- Change Node.js requirement in `engines.node` to `>=6`. Use
  `please-upgrade-node` to give helpful error message on older versions.
- Remove node 4 from list of Node.js versions to test on CI. Also remove
  `--ignore-engines` flag for `yarn install`, not required with node 6.
- Add note to readme for Node.js version requirement.
- Target node 6 for `babel-preset-env` (relevant only for tests).
- Add eslint rule for `prefer-destructuring`, do relevant code changes.
- Use default argument for `logger` passed to `src/index.js`

BREAKING CHANGE: Requires Node.js v6 or later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants