Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide err msg in private field to avoid duplicate logs #421

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

sudo-suhas
Copy link
Collaborator

This hides the error message in a private field to get around the duplicate logs issue. Most of the credit goes to @umarmw for the idea, so thank you!

Closes #142, #308, #406, #415.

@codecov
Copy link

codecov bot commented Mar 31, 2018

Codecov Report

Merging #421 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   98.14%   98.17%   +0.02%     
==========================================
  Files          11       11              
  Lines         216      219       +3     
  Branches       24       25       +1     
==========================================
+ Hits          212      215       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/printErrors.js 100% <100%> (ø) ⬆️
src/runScript.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea8b06...30d62d4. Read the comment docs.

Copy link
Collaborator

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants