fix: update "please-upgrade-node" to version 3.0.2 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes semantic version range checking that avoids incorrect flagging of Node.js version 10+
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 11 11
Lines 220 220
Branches 25 25
=======================================
Hits 216 216
Misses 4 4Continue to review full report at Codecov.
|
|
Released in v7.0.5 🎉 |
This was referenced Apr 26, 2018
gitgrimbo
added a commit
to gitgrimbo/intern
that referenced
this pull request
Jun 26, 2018
lint-staged/lint-staged#434 Includes semantic version range checking that avoids incorrect flagging of Node.js version 10+. typicode/please-upgrade-node#11 E.g.: ``` node --version v10.3.0 ``` and: ``` git commit -m "fix(html reporter): toggle visibility in IE11" src/lib/reporters/Html.ts lint-staged requires at least version 6 of Node, please upgrade pre-commit: pre-commit: We've failed to pass the specified git pre-commit hooks as the `precommit` pre-commit: hook returned an exit code (1). If you're feeling adventurous you can pre-commit: skip the git pre-commit hooks by adding the following flags to your commit: pre-commit: pre-commit: git commit -n (or --no-verify) pre-commit: pre-commit: This is ill-advised since the commit is broken. pre-commit: ```
gitgrimbo
added a commit
to gitgrimbo/intern
that referenced
this pull request
Jun 26, 2018
lint-staged/lint-staged#434 Includes semantic version range checking that avoids incorrect flagging of Node.js version 10+. typicode/please-upgrade-node#11 E.g.: ``` node --version v10.3.0 ``` incorrectly causes: ``` git commit -m "fix(html reporter): toggle visibility in IE11" src/lib/reporters/Html.ts lint-staged requires at least version 6 of Node, please upgrade pre-commit: pre-commit: We've failed to pass the specified git pre-commit hooks as the `precommit` pre-commit: hook returned an exit code (1). If you're feeling adventurous you can pre-commit: skip the git pre-commit hooks by adding the following flags to your commit: pre-commit: pre-commit: git commit -n (or --no-verify) pre-commit: pre-commit: This is ill-advised since the commit is broken. pre-commit: ```
jason0x43
pushed a commit
to theintern/intern
that referenced
this pull request
Jul 2, 2018
lint-staged/lint-staged#434 Includes semantic version range checking that avoids incorrect flagging of Node.js version 10+. typicode/please-upgrade-node#11 E.g.: ``` node --version v10.3.0 ``` incorrectly causes: ``` git commit -m "fix(html reporter): toggle visibility in IE11" src/lib/reporters/Html.ts lint-staged requires at least version 6 of Node, please upgrade pre-commit: pre-commit: We've failed to pass the specified git pre-commit hooks as the `precommit` pre-commit: hook returned an exit code (1). If you're feeling adventurous you can pre-commit: skip the git pre-commit hooks by adding the following flags to your commit: pre-commit: pre-commit: git commit -n (or --no-verify) pre-commit: pre-commit: This is ill-advised since the commit is broken. pre-commit: ```
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes semantic version range checking that avoids incorrect flagging of Node.js version 10+. typicode/please-upgrade-node#11
Resolves #432
Edit: Closes #433