Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceApi is missing in sdk client #386

Closed
julron opened this issue Apr 16, 2023 · 10 comments · Fixed by #389
Closed

DeviceApi is missing in sdk client #386

julron opened this issue Apr 16, 2023 · 10 comments · Fixed by #389

Comments

@julron
Copy link

julron commented Apr 16, 2023

Describe the feature request?

DeviceApi (ObjectDeviceApi) is missing in list of Client object apis

New or Affected Resource(s)

7.0.0

Provide a documentation link

export declare class ObjectDeviceApi {

Additional Information?

Is it possible to add deviceApi to the client as well?
Thank you

@denysoblohin-okta
Copy link
Contributor

Thanks for submitting this issue. deviceApi should be added to client.
Internal ref: OKTA-602351

@az-nextsec
Copy link

I still can't see it in version 7.0.1 which is the latest version?

@denysoblohin-okta
Copy link
Contributor

Yes, 7.0.1 is the latest version.
Device Api should be available

import { Client, Device } from '@okta/okta-sdk-nodejs';
const client = new Client(...);
const collection = await client.deviceApi.listDevices({
  limit: 1
});
const { value: device } = await collection.next(); // access the first item of the collect
console.log(device);

@az-nextsec
Copy link

@denysoblohin-okta I am happy to show you that it is not available.

If you download your source code from this repo as of 7.0.1 tag it is NOT included:
https://github.com/okta/okta-sdk-nodejs/releases/tag/okta-sdk-nodejs-7.0.1

@az-nextsec
Copy link

You can also see it in the github tree here, DevicesApi is not imported. It is present on master, but NOT in 7.0.1

https://github.com/okta/okta-sdk-nodejs/blob/okta-sdk-nodejs-7.0.1/src/client.js#L55

@az-nextsec
Copy link

@denysoblohin-okta you can see in master it is on line 56, but not in 7.0.1

https://github.com/okta/okta-sdk-nodejs/blob/master/src/client.js#L56

@denysoblohin-okta
Copy link
Contributor

Sorry, you're correct.
New version 7.1.0 should be released, it will contain DeviceApi

@az-nextsec
Copy link

@denysoblohin-okta do you have an ETA for this?

@sutru
Copy link

sutru commented May 16, 2024

this fix appears to still be missing a listDeviceUsers method

@denysoblohin-okta
Copy link
Contributor

@az-nextsec
Please update to 7.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants