Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_source_okta_user - Add "skip_roles" to okta_user data source documentation #1900

Closed
stargonautone opened this issue Feb 15, 2024 · 2 comments
Labels
enhancement Asking for new behavior or feature triaged Triaged into internal Jira

Comments

@stargonautone
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The skip_roles argument was removed from the documentation for the okta_user data source as of version 4.0.0, yet is still available and required if being used by a non-SuperAdmin (if skip_roles = true is omitted, non-SuperAdmin may get the error Error: failed to set user's roles: failed to get roles: the API returned an error: You do not have permission to perform the requested action).

https://registry.terraform.io/providers/okta/okta/4.7.0/docs/data-sources/user

The skip_roles argument should be added back in to the documentation, or okta_user should be brought in line with the okta_users data source which uses the optional include_roles argument which is assumed false if not specified in terraform.

New or Affected Resource(s)

  • okta_user

Potential Terraform Configuration

data "okta_user" "foobar" {
    # skip_roles = true
  search {
    name = "profile.firstName"
    value = "foo"
  }

  search {
    name = "profile.lastName"
    value = "bar"
  }
}

References

@stargonautone stargonautone added the enhancement Asking for new behavior or feature label Feb 15, 2024
@duytiennguyen-okta
Copy link
Contributor

OKTA internal reference https://oktainc.atlassian.net/browse/OKTA-699599

@duytiennguyen-okta duytiennguyen-okta added the triaged Triaged into internal Jira label Feb 21, 2024
@duytiennguyen-okta
Copy link
Contributor

Close via #1705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Asking for new behavior or feature triaged Triaged into internal Jira
Projects
None yet
Development

No branches or pull requests

2 participants