Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use all (default) features for the tracing crate #16

Open
JAicewizard opened this issue Feb 23, 2021 · 4 comments
Open

Dont use all (default) features for the tracing crate #16

JAicewizard opened this issue Feb 23, 2021 · 4 comments

Comments

@JAicewizard
Copy link

This adds a lot of dependencies, even for non-wasm targets. For https://github.com/linebender/druid this seems to be around ~24 added deps.

@JAicewizard
Copy link
Author

I can file a PR tomorrow if this would speed up fixing this

@colelawrence
Copy link
Member

@JAicewizard thanks for bringing this up! I'm not super familiar with feature settings in Cargo.toml.

If you set that up in a PR I'd do my best to merge it quickly and make a release for you! It would be great to have our library help with the linebender project.

@colelawrence
Copy link
Member

I tried it out on our repo here at Storyscript, and disabling default features for tracing and tracing-subscriber didn't break anything, so I made that update and pushed a new release 0.2.0 from master branch.

Please feel free to share feedback!

@JAicewizard
Copy link
Author

Looks good, I will test when I get the time for it. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants