Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Float used in spite of flex grid #1005

Closed
MarineLB opened this issue Jun 21, 2017 · 2 comments
Closed

Float used in spite of flex grid #1005

MarineLB opened this issue Jun 21, 2017 · 2 comments

Comments

@MarineLB
Copy link

Hello,
I am using FoundationPress on a new project.
I commented @include foundation-grid; and decommented @include foundation-flex-grid; to use the new flex grid, as I always do.
However, in a single page, article.main-content and .sidebar have the css float property.
Therefore, the footer is broken and appears in the middle of the page.
By adding float:none; to both of them, the issue is resolved.
Is this standard behavior ? Because it doesn't seem logical to still use float when we're using flex grid.

Thanks :)

@dantahoua
Copy link
Contributor

What I do when using Flex (always for 6 month now) is commenting @include foundation-grid; AND @include foundation-float-classes;
I uncomment @include foundation-flex-classes; AND @include foundation-flex-grid;
Never add problem after (maybe with he Offcanvas menu if I recall well, but not sure...)

@MarineLB
Copy link
Author

Oh wow thank you @dantahoua I had totally missed this foundation-float-classes line in the docs !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants