Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Broken layout for IE9 #117

Closed
mordant23 opened this issue Sep 26, 2014 · 6 comments
Closed

Broken layout for IE9 #117

mordant23 opened this issue Sep 26, 2014 · 6 comments

Comments

@mordant23
Copy link

The layout and look of the theme does not look right in Internet Explorer 9. It's easily seen when taking a look in IE9 at the Kitchen Sink page for FoundationPress versus the the Kitchen Sink page for Foundation. I'm not sure why the layout breaks for IE9. One specific issue that I know of is "show-for-small-only" class displays on large and medium screens.

@Protazy21
Copy link

Can confirm the bug. In my case it looks like css isn't loaded at all, however app.css apperas in the page source.

@olefredrik
Copy link
Owner

This issue might be related to this #114 , where app.css gets bloated due to a compile error when using libsass. Zurb have confirmed there will be an official patch released next week.

@olefredrik
Copy link
Owner

Rolled back to Foundation 5.3.2 (temporary fix until the Foundation team provides an official patch to the libsass issue). Could you pull the latest commit and check if the IE9 layout issue is still valid?

@Protazy21
Copy link

On 29/09/2014 18:12, Ole Fredrik Lie wrote:

pull the latest commit
Hi there,
I pulled the latest commit, activated new theme, made a change of
background color, grunt returned no errors. I'm happy to confirm that
everything works as it should in IE9.
Kind regards
Pawel

@olefredrik
Copy link
Owner

Awesome! 👍

@mordant23
Copy link
Author

Not sure if this is the correct place to put this. I didn't realize Foundation axed support for SASS version 3.4. The rollback fixed the layout, but it broke again after another compile of sass using grunt watch. Turns out my version of SASS was 3.4.2. When I upgraded to SASS 3.4.5 and ran grunt build, the layout worked on IE9.
Edit: Actually this didn't quite work. The issue is that Mac OSX doesn't have a package system that can rollback versions of software and I couldn't find a build for SASS 3.3. I had to run "bower install foundation#5.3.2" to get the correct version of Foundation that would work with SASS 3.4.5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants