Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

foundation.css vs app.css #172

Closed
Aetles opened this issue Dec 15, 2014 · 2 comments
Closed

foundation.css vs app.css #172

Aetles opened this issue Dec 15, 2014 · 2 comments

Comments

@Aetles
Copy link
Contributor

Aetles commented Dec 15, 2014

In the latest changes the main css output has been renamed from app.css to foundation.css. Maybe it's just me but foundation.css sounds like the Foundation css rather than the entire theme css that also includes my own custom css. I'm just curious, why the change?

Anyway, now that it is changed, should bower.json also change? It seems to refer to the old names of css and js output files:

  "main": [
    "css/app.css",
    "js/app.js"
  ],
@Waqass
Copy link

Waqass commented Dec 15, 2014

Yes they all have been updated recently....bower, grunt....thus compiling to different folders thus paths also changed in functions.php. I'm currently sticking to the previous version before updating as it would mess with my in progress work.

@olefredrik
Copy link
Owner

@Aetles : I noticed that Zurb have changed the naming of app.css to foundation.css in the main repository for Foundation. I suppose this is to avoid confusion between Foundation for Sites and Foundation for Apps? It's not a big deal in a larger context, but I think it is a good idea to stay close to the conventions of Foundation.

zurb-foundation

Regarding your comment on the bower.json file, you're right. Well spotted, thanks! Fixed 06d60b6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants