Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Recommended SASS customizations? #207

Closed
adaptifyDesigns opened this issue Feb 7, 2015 · 3 comments
Closed

Recommended SASS customizations? #207

adaptifyDesigns opened this issue Feb 7, 2015 · 3 comments

Comments

@adaptifyDesigns
Copy link

Are you recommending that we add our custom styles to _base.scss? Or that we start new .scss files and add them to the foundation.scss sheet as imports?

In the same line of thought, is there a recommendation for updating the core theme when you push updates?

Just trying to make sure I future proof this theme before I start building. Thanks for any help/suggestions. And thanks a lot for this theme!

@joshsmith01
Copy link
Contributor

+1

@olefredrik
Copy link
Owner

I prefer personally to divide up styling in relation to various components, and include these in foundation.scss.

For example:
import "site/base";
import "site/sidebars";
import "site/buttons";

... And so on. In this way I get a better overview and structure. It gives me greater flexibility than if I'd had all the styling in the same file. Grunt ensures that the output is just one minified file, so you don't have to worry about many http requests and slow loading times.

To answer your second question, this can be solved by doing a git pull origin master. Note that you may need to handle merge conflicts that must be resolved if the same files are modified both locally and remote. Merge conflicts is however a common part of Git, and can be easily solved with a variety of free tools.

Having said this, there is no definitive answer your questions. I recommend that you play around and find the way that best suits your workflow.

Good luck and have fun :)

@themestechnology
Copy link
Contributor

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants