You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should make all of the WebDriver methods protected instead of private to allow it to be extended and modified as required.
There are a couple of valid reasons to do this, but amongst them to there is sometimes a need to make changes which will not be accepted by the project.
As it stands the only ways to do this right now is to fork the project, and add it to the repositories list in composer.json, to use Reflection, or to copy large amounts of code. The fact that this project has had to completely rewrite the Selenium2 driver rather than just extend it and fix the relevant parts is a sign of that too.
So IMHO we should really update all methods to be protected instead of private.
The text was updated successfully, but these errors were encountered:
I'm okay with it. Also we would benefit from an extra interface it's useful for decorators. Interface probably should define extra methods e.g.: hasAttribute, clickOnElement, executeAsyncScript
but I'm not sure that methods like ensureInputType, keyModifier, decodeChar should be protected.
I think we should make all of the WebDriver methods protected instead of private to allow it to be extended and modified as required.
There are a couple of valid reasons to do this, but amongst them to there is sometimes a need to make changes which will not be accepted by the project.
As it stands the only ways to do this right now is to fork the project, and add it to the repositories list in composer.json, to use Reflection, or to copy large amounts of code. The fact that this project has had to completely rewrite the Selenium2 driver rather than just extend it and fix the relevant parts is a sign of that too.
So IMHO we should really update all methods to be protected instead of private.
The text was updated successfully, but these errors were encountered: