Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when a test has two @only-target? #295

Open
RalfJung opened this issue Nov 10, 2024 · 1 comment
Open

Warn when a test has two @only-target? #295

RalfJung opened this issue Nov 10, 2024 · 1 comment

Comments

@RalfJung
Copy link
Collaborator

I just realized that we recently accidentally disabled a test in Miri... I wonder if we should warn against having multiple @only-target?

OTOH that could be legitimate when it's something like

// Only on linux on x86 (32/64) targets
@only-target: linux
@only-target: 86
@oli-obk
Copy link
Owner

oli-obk commented Nov 10, 2024

We could allow regexes in the pattern and then forbid there being multiple only-target or only-host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants