Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast.Design stylesheet #3342

Closed
MarcSkovMadsen opened this issue Jun 26, 2021 · 3 comments
Closed

Fast.Design stylesheet #3342

MarcSkovMadsen opened this issue Jun 26, 2021 · 3 comments
Labels
Feature Large feature update Help Needed This is a good option for a PR from the comunity

Comments

@MarcSkovMadsen
Copy link

MarcSkovMadsen commented Jun 26, 2021

I am a data scientist using HoloViz Panel, templates based on Microsofts Fast.Design like FastListTemplate and the Panel Tabulator widget.

I would like the style of the Fast design templates and Tabulator to play nicely together. So I've created a stylesheet for using Tabulator with Fast design in any application.

You can find it here https://github.com/MarcSkovMadsen/awesome-panel-assets/tree/master/styles for now.

I would like to make it easier for Fast and Tabulator developers in general and Panel developers in particular to use this stylesheet.

One solution would be to get it added to the Tabulator list of stylesheets.

Would you be interested?

fast-tabulator-stylesheet-x2.mp4

Additional Context

If you are interested you can find a Panel example with code here https://discourse.holoviz.org/t/tabulator-style-for-fast-templates/2478

I am also working on a PR to Panel for adding this stylesheet as one of the supported themes for the Panel Tabulator widget. See holoviz/panel#2425.

@MarcSkovMadsen MarcSkovMadsen added the Suggested Feature A suggested feature that is waiting review label Jun 26, 2021
@olifolkerd
Copy link
Owner

Hey @MarcSkovMadsen

I would be happy to add a new theme to Tabulator, if you would like to see it included, please submit a PR against the 5.0 branch.

You could also add a link to the Tabulator Ideas repo to help point other people at it.

Cheers

Oli :)

@olifolkerd olifolkerd added Feature Large feature update and removed Suggested Feature A suggested feature that is waiting review labels Jul 4, 2021
@olifolkerd
Copy link
Owner

Hey @MarcSkovMadsen

Just wondering if you are still interesting in submitting a PR for this (against the 5.1 branch now).

If not i will close of this issue to reduce clutter.

Cheers

Oli :)

@MarcSkovMadsen
Copy link
Author

Hi @olifolkerd

Thanks for asking. I would like to contribute a PR but have too many other things going on right now.

Feel free to close this one.

@olifolkerd olifolkerd added the Help Needed This is a good option for a PR from the comunity label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Large feature update Help Needed This is a good option for a PR from the comunity
Projects
None yet
Development

No branches or pull requests

2 participants