Fix Windows compatibility #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olirice
requested changes
Apr 29, 2024
| @@ -66,8 +65,6 @@ def main(argv: Optional[List[str]] = None) -> None: | |||
| if _file: | |||
| _ = flu(read_file(_file)).map(str.rstrip) | |||
| else: | |||
| # Do not raise exception for Broken Pipe | |||
| signal(SIGPIPE, SIG_DFL) | |||
There was a problem hiding this comment.
this is necessary to resolve broken pipe exceptions on unix systems
how about
import platform
...
if platform.system() != 'Windows':
from signal import SIG_DFL, SIGPIPE, signal
signal(SIGPIPE, SIG_DFL)
...There was a problem hiding this comment.
Sure, I think at that point it may be best to wrap with try/catch ImportError instead of explicitly checking platform... that way it'll continue to work on any other platforms that don't have SIGPIPE.
Do you have a way to reproduce the broken pipe exception on Unix? I tried a couple different ways but never got it to happen.
There was a problem hiding this comment.
try:
flu 'flu(count())' -i 'itertools:count' | head -n 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33.
The
SIGPIPEsignal is not available on Windows, so its import fails on that platform.Upon further investigation, the
SIGPIPEsignal is already handled by Python by default,so the
signal(SIGPIPE, SIG_DFL)call shouldn't actually do anything...Currently untested on Windows, but did test that this change does not adversely affect Linux.Will remove draft status once tested on Windows.
Changes tested on both Linux (Ubuntu 22.04, Python 3.10) and Windows (Windows 10, Python 3.12).