-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkIndexBounds off by 1 validation #650
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
checkIndexBounds
is too lenient and allows setting indexes from0 .. count
inclusive, whereas really the only valid values are0 .. (count-1)
.react-swipeable-views/packages/react-swipeable-views-core/src/checkIndexBounds.js
Lines 9 to 12 in a12dd90
Current Behavior
The warning is only produced after setting
index
tochildren.length + 1
:Here is an example warning I see when I set
index = 4
having only 3 children:Expected Behavior
Setting
index
to exactlychildren.length
should already produce a warning. The warning message should also show the correct range of values.E.g. setting
index
to3
should produce this warning when there are only 3 children:Steps to Reproduce
This should produce a warning, but it doesn't:
Context
This is a minor dev nuisance, where the lenience of react-swipable-views is potentially allowing a dev to not detect code defects.
Your Environment
The text was updated successfully, but these errors were encountered: