You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a user who is trying to build kubit from source, which pulls in kubert as a dependency. The user OS is Windows. They run into an issue with respect to signal handling in the shutdown module of this crate because it unconditionally uses tokio::signal::unix
It looks like there is a tokio::signal::windows module available that could be conditionally compiled based on platform feature flags, but the logic around signal handling will probably have to be different for each since it looks like the two platforms provide different approaches to signal handling.
The text was updated successfully, but these errors were encountered:
I do wonder if it even makes sense for kubit to be using kubert's shutdown module at all given that it would only be relevant when kubit is run in "controller mode", not in a CLI mode (as far as I can tell).
I have a user who is trying to build
kubit
from source, which pulls inkubert
as a dependency. The user OS is Windows. They run into an issue with respect to signal handling in theshutdown
module of this crate because it unconditionally usestokio::signal::unix
It looks like there is a
tokio::signal::windows
module available that could be conditionally compiled based on platform feature flags, but the logic around signal handling will probably have to be different for each since it looks like the two platforms provide different approaches to signal handling.The text was updated successfully, but these errors were encountered: