Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails on windows #251

Open
waynr opened this issue May 14, 2024 · 1 comment
Open

Compilation fails on windows #251

waynr opened this issue May 14, 2024 · 1 comment

Comments

@waynr
Copy link

waynr commented May 14, 2024

I have a user who is trying to build kubit from source, which pulls in kubert as a dependency. The user OS is Windows. They run into an issue with respect to signal handling in the shutdown module of this crate because it unconditionally uses tokio::signal::unix

It looks like there is a tokio::signal::windows module available that could be conditionally compiled based on platform feature flags, but the logic around signal handling will probably have to be different for each since it looks like the two platforms provide different approaches to signal handling.

@waynr
Copy link
Author

waynr commented May 14, 2024

I do wonder if it even makes sense for kubit to be using kubert's shutdown module at all given that it would only be relevant when kubit is run in "controller mode", not in a CLI mode (as far as I can tell).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant