Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPI value? #30

Closed
cmahnke opened this issue Aug 8, 2024 · 4 comments
Closed

DPI value? #30

cmahnke opened this issue Aug 8, 2024 · 4 comments

Comments

@cmahnke
Copy link

cmahnke commented Aug 8, 2024

Usually Pillow plugins provide some metadata in the info, dpi for example - this value is missing for jxlpy. Is there another way to get this information?

@cmahnke
Copy link
Author

cmahnke commented Aug 8, 2024

Ok, actually I was a bit shocked to learn that JXL doesn't bother to provide even the required infrastructure, see:

Not sure how to proceed, since this means I can't use JXL for easy creation of PDF...

@olokelo
Copy link
Owner

olokelo commented Aug 8, 2024

I think in this case the best solution would be to use Exif tags however doing that in jxlpy is not yet supported.
If it's possible in your workflow you could probably use Exiftool as described here.
I might add Exif support to jxlpy in the future as I already implemented it for the internal Pillow Plugin.

@cmahnke
Copy link
Author

cmahnke commented Aug 8, 2024

Ok, thanks - I was afraid that this might be the outcome...

Should I keep this issue open as a remainder?
Do you plan to abandon this (the project), after your PR has been merged?

@olokelo
Copy link
Owner

olokelo commented Aug 9, 2024

I don't have plans on abandoning this project, maybe just removing the Pillow plugin if it would already be in the upstream. High bit depths are not well supported in Pillow so using jxlpy would still make sense for that case, also there's JPEG lossless recompression feature although it's also not yet supported here.

I would encourage to still use Pillow plugin if you only need decoding support of 8 bit images since it's better written and doesn't have Cython dependency.

I will close the issue for now, feel free to reopen if you ever need to :)

@olokelo olokelo closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants