Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the $inject property in an existing line #81

Closed
mgol opened this issue Sep 25, 2014 · 4 comments
Closed

Define the $inject property in an existing line #81

mgol opened this issue Sep 25, 2014 · 4 comments

Comments

@mgol
Copy link

mgol commented Sep 25, 2014

Currently, ng-annotate mostly preserves lines and columns, making it easy to use during debugging even without relying on source maps.

Unfortunately, annotating via the $inject property breaks that invariant as shown in an example from issue #63.

Would it be possible to "append" the definition to an existing line so the invariant can be preserved in all cases again?

@olov
Copy link
Owner

olov commented Sep 25, 2014

That's a good suggestion. No added newlines by default and an optional switch for the current behavior?

@mgol
Copy link
Author

mgol commented Sep 25, 2014

Seems fine, for people that prefer to have more readable generated code.

@ruhnowg
Copy link

ruhnowg commented Oct 14, 2014

👍

@olov
Copy link
Owner

olov commented Jun 8, 2016

#245

@olov olov closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants