Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constant time comparison function #122

Closed
tiran opened this issue Dec 6, 2013 · 1 comment
Closed

Use constant time comparison function #122

tiran opened this issue Dec 6, 2013 · 1 comment

Comments

@tiran
Copy link

tiran commented Dec 6, 2013

social.backend.facebook compares HMAC signatures with '=='. That's insecure and may leak information. You should use a function like http://docs.python.org/3/library/hmac.html#hmac.compare_digest. Django has a Python implementation of the function, too.

@omab omab closed this as completed in 58cd182 Dec 7, 2013
@omab
Copy link
Owner

omab commented Dec 7, 2013

Fixed, thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants