Return 503 instead of raise 500 error when auth provider not accessible

[zee-why]

I'm using python-social-auth with Django. Url configs as:
url('', include('social.apps.django_app.urls', namespace='social'))
Currently, when auth providers are not accessible or there is any error returned from provider, python-social-auth always raise an error which makes 500 response. From my point of view, when auth provider not accessible, it's more reasonable to return a 503 instead of raising 500. 500 is not good to SEO. What's your opinion on it?

[omab]

You can easily implement that behavior by subclassing the built-in middleware here https://github.com/omab/python-social-auth/blob/master/social/apps/django_app/middleware.py

[zee-why]

Thanks for point out the built-in middleware.

I tried it, then found a small issue here: https://github.com/omab/python-social-auth/blob/master/social/backends/oauth.py
Unlike BaseOAuth2.auth_complete, the BaseOAuth2.do_auth doesn't handle HTTPError (similar issue may also exist somewhere else). As a result, errors from do_auth won't be handled by SocialAuthExceptionMiddleware. If I write a custom middleware, I can check URL to determine where the HTTPError come from. It's an OK solution, but seems not very elegant to me. Are there any considerations of why do_auth not handling HTTPError like auth_complete?

[omab]

There's no reason for do_auth not handle HTTPError, the code is just missing and I'll add it soon.