Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually Log Exceptions in SocialAuthExceptionMiddleware #507

Closed
clintonb opened this issue Feb 5, 2015 · 0 comments
Closed

Actually Log Exceptions in SocialAuthExceptionMiddleware #507

clintonb opened this issue Feb 5, 2015 · 0 comments

Comments

@clintonb
Copy link
Contributor

clintonb commented Feb 5, 2015

The doc for SocialAuthExceptionMiddleware states that it logs an error. It doesn't. If an exception is not raised the middleware attempts to display the error to the user via the messages framework or pass the message as a query string parameter.

The middleware should actually log the exception. Otherwise, if the error view does not use the messages framework, the error will be hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant