Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DASH video corruption seemingly at random #193

Closed
Discookie opened this issue Sep 29, 2018 · 5 comments
Closed

DASH video corruption seemingly at random #193

Discookie opened this issue Sep 29, 2018 · 5 comments
Labels
bug Something isn't working stale

Comments

@Discookie
Copy link

Discookie commented Sep 29, 2018

I've been watching DASH videos, and this is the second time I've had a corrupted video like this one.

image

There's sometimes a full-screen color change, but otherwise only the top few rows change.

image

It looks like the video files are somehow misaligned? It might come from proxying dropping a bit of data, or from a bug in the DASH player. A refresh fixes it, and usually after a minute or so it fixes itself.

I couldn't find a way to reproduce this issue reliably, but here's the link anyways:
https://invidio.us/watch?v=-LytcXun4hU

I've had this issue on 2 separate machines, on Waterfox 56.2.3 on Win10/AMD and a Chromium 69.0 on Win8.1/Nvidia.

@omarroth
Copy link
Contributor

Does it reliably happen ~x seconds into the video? It might be the case that Invidious is generating a bad manifest that results in an incorrect offset like what appears to be encountered. Does devtools show any errors?

Currently, Invidious uses videojs/videojs-contrib-dash, because videojs/http-streaming does not yet support features that Invidious uses in its manifests. I suspect the issue is in the player since it disappears after a refresh, and I think this issue will likely go away after switching to http-streaming.

@Discookie
Copy link
Author

Discookie commented Oct 4, 2018

Found a semi-reliable way to reproduce it, and it looks more like a player issue:
Simply jump forward with the arrows to the very end of the buffer.
If you get unlucky, your video will corrupt the same way.

dash.mediaplayer.min.js throws this warning:

[496953][Stream] onBufferingCompleted - can't trigger STREAM_BUFFERING_COMPLETED because streamProcessor audio is not buffering completed

The audio and the corrupted video continued without interruption.

A potential fix would be to stop the video and wait for buffer ~1s before the end of the buffer?

@omarroth omarroth added the bug Something isn't working label Oct 13, 2018
@omarroth
Copy link
Contributor

omarroth commented Apr 28, 2019

Switched over to http-streaming with 075adb4 which should hopefully resolve this issue.

@Discookie
Copy link
Author

Encountered it the very first time I tried to switch resolutions with the new source selector :/

Although it's starting to smell more like hardware issues, because Streamable's being corrupted on the AMD machine too. GPU/decode stress testing didn't report anything so far, but I'll keep testing.

@github-actions
Copy link

github-actions bot commented Dec 2, 2020

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Dec 2, 2020
@github-actions github-actions bot closed this as completed Jan 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants