running role on its own wiped top_links

[atarkowska]

Running role https://github.com/IDR/deployment/pull/9/files#diff-859e93e6ca33aa77acc85c0429403580R55 with default deployment vars in a upgrade context wiped top_links omero.web.ui.top_links=[]. Would be really nice if existing config is not affected in an upgrade mode

[manics]

It was run with a config file that explicitly sets it to []: https://github.com/IDR/deployment/blob/3f41abc22bd9e8e9e6a0ac9da7e306533db9faef/ansible/files/IDR-OMERO-52-omero.j2#L58

[atarkowska]

I need to disagree, it was run with default group_vars, so I would expect not to change any state. Ideally would be to provide clear explanation what extra should be included on top of the server role to not change the state

[manics]

Those vars/options are set in a playbook in another repo, it's unrelated to this role.

[manics]

I think the best solution to this is ome/design#70

[joshmoore]

@aleksandra-tarkowska : you ok with the status of this in ome/design#70 ?

[joshmoore]

@manics: I'm assuming this is good to close then. Can re-open if you think this has any remaining TODOs.