Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chown in clients #77

Open
pwalczysko opened this issue Jun 22, 2017 · 6 comments
Open

chown in clients #77

pwalczysko opened this issue Jun 22, 2017 · 6 comments

Comments

@pwalczysko
Copy link
Member

pwalczysko commented Jun 22, 2017

Scoping of Change Owner

Group Owners and Admin to be given ability to change owner of data in their groups.

Use Cases:

• user leaves lab/institute and ownership of data needs to be transferred to another researcher.
• one user imports data for another user.

Options:

Perform on selection of:

  • single image - image
  • multi-selected images - all images
  • dataset - dataset and all images contained
  • project - project, contained datasets and contained images

Presume:

Will allow selection of data belonging to more than one owner.
Will allow owner to be “changed” to same owner, so if there is data in dataset owned by several users, including the “new owner” - so the group owner does not have to worry to separate those out.
The ownership of any annotations attached to images will be unaffected.

Using right-click menu

New owner selection and confirmation dialog.

  • styled like Group-user display menu (minus the checkboxes!)

Checkboxes to include/exclude change ownership of enclosed:

  • images - available if dataset selected - default = selected
  • datasets - available if project selected - default = selected

Images only selected:
picture1

Dropdown menu allows selection of new owner:
picture2

Dataset selected:
picture3

Project selected:
picture4

To deal with the requirement to change all data in all groups belonging to a user in one go:

  • it would be possible to have a dialog where you select the “user to be changed” and “changed to user” but this seems unnecessarily complicated as a first step.
@pwalczysko
Copy link
Member Author

@will-moore @jburel @mtbc @joshmoore : See above what I found as Word doc done by Gus and re-formatted it here to github issue format.

I think this is a workable prototype, questions:

  • what if the images under selected Dataset or Datasets under selected Project are of mixed ownership ? (the dialog above assumes chown will transfer all contained entities, but is this possible in mixed case ? (webclient would have to do some queries, possible ?)
  • the possible recipients are the ones in the group, I think the "myself", ie. Admin or lightAdmin performing the chown should be added to the list as well ?
  • the annotations are not being dealt with here at all -> how about another checkbox for annotations ? (would behave as --include Annotations on CLI when checked)

@pwalczysko
Copy link
Member Author

also see https://trello.com/c/0icOEIqM/12-rfe-enable-creation-of-p-d-s-on-behalf-of-others-in-web#comment-58fa0bdf0e975a5deee1b5f3 - these two workflows (create container for others and chown) have to be thought through

@mtbc
Copy link
Member

mtbc commented Jun 22, 2017

In RW groups chown still won't want to descend into mixed-owner container hierarchies, one'd have to specify all the target objects explicitly; probably the same for annotations.

@mtbc
Copy link
Member

mtbc commented Jun 22, 2017

(Below RW chown will sometimes do some unlinking or deletion: e.g., chowning an image in a RA group probably unlinks it from datasets.)

@pwalczysko
Copy link
Member Author

chowning an image in a RA group probably unlinks it from datasets.)

Yes, it does, tested on eel merge.

@pwalczysko
Copy link
Member Author

pwalczysko commented Jun 22, 2017

Situation:
user-in-RA's-Project-admin's-link-admin's-dataset-user-in-RA's-Image hierarchy

Chown on the Project (to another user in RA) will unlink the Project to the Dataset. I do not see a justification for this, to be honest. This does not follow the logic because it could not have been created in that group in the first place, it must be severed. No, this could (and was) created by the admin in that group.

Edit: And adding --include Image does not help, the hierarchy gets broken anyway, the image will not be chowned.
Edit: And specifying "all images under that project" using Project/Dataset/Image:ProjectID does not help either when the hierarchy is mixed, no images will get chowned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants