Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix masks.[].image.array to match spec #19

Closed
wants to merge 2 commits into from

Conversation

manics
Copy link
Member

@manics manics commented Jul 21, 2020

Also add docs for masks.py methods

Closes ome/omero-ms-zarr#57

Also add docs for masks.py methods
src/omero_zarr/masks.py Outdated Show resolved Hide resolved
@joshmoore
Copy link
Member

The code here generally makes sense, but I'm unsure what http://github.com/ome/ome-zarr-py is intended to do if it finds one of these remote URLs.

Sorry for having missed the merging of ome/omero-ms-zarr@6add680#r450996719, but I think at the moment, the "image" key is in a bit of an intermediate state. E.g. what do you intend with the "source" subkey?

@manics
Copy link
Member Author

manics commented Jul 23, 2020

The code here generally makes sense, but I'm unsure what http://github.com/ome/ome-zarr-py is intended to do if it finds one of these remote URLs.

For now nothing, since all our masks are in the same Zarr as the image data. In future it could load the data. Alternatively this could be managed at the application level, where a user could choose to fetch the image or not.

If it's a relative URL the viewer it should only show the mask if that array is displayed. This handles @jburel's requirement to generate masks using a lower resolution from a pyramid.

what do you intend with the "source" subkey?

I've taken it out for now, it's become less useful as we've developed the spec.

joshmoore added a commit to joshmoore/omero-ms-zarr that referenced this pull request Aug 19, 2020
@joshmoore
Copy link
Member

cf.

With the change to multiscales, the logic here is somewhat in flux. I'd like to simplify this by not dealing with URLs for the moment, i.e. rolling back to the change to the spec. See: ome/omero-ms-zarr@da260f2

I've simplified the naming down to "source-image" in #25, but happy to move to your naming once we're ready to expose "federated" datasets that link remotely.

A more immediate next change will be to rename the image.array key and integrate it with the rest of the labels metadata (color, etc.) Once all of that is done, would be good to get your docs from here open against the mainline.

@joshmoore joshmoore closed this Aug 19, 2020
@manics manics deleted the mask-spec-cleanups branch October 22, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify supported URLs protocol in the image key for masks
3 participants