Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how web-apps should be configured #30

Open
manics opened this issue Feb 12, 2019 · 4 comments
Open

Document how web-apps should be configured #30

manics opened this issue Feb 12, 2019 · 4 comments
Assignees

Comments

@manics
Copy link
Member

manics commented Feb 12, 2019

The only example of a web-app that requires configuration is mapr: https://github.com/ome/omero-mapr/blob/0.2.3/.omeroci/app-config
But the configuration file /opt/omero/web/config/10-mapr.omero is ignored because the config files are only loaded on startup, and the OMERO.web Docker container is already running.

@joshmoore
Copy link
Member

Do you know of a mechanism that would allow what's attempted here?

@manics
Copy link
Member Author

manics commented Feb 13, 2019

You'd need to install the app and the config before starting the container. In practice that probably means building the container in docker-compose (run the app-config and install scripts at build time). Conveniently that could also deal with #29

@joshmoore
Copy link
Member

With the current setup, probably the only way to make that work would be to either have the equivalent of app-config in the app's Dockerfile or to have a whole infra directory:

# docker-compose.yml
build: ../.omeroci/infra-image

(if the latter will even work)

@manics
Copy link
Member Author

manics commented Feb 19, 2019

I briefly tried that last week, and it turned out to be more complicated since you effectively need to run all the app stages during build, which means rearchitecting this repo. A separate infra-image dir would work but means duplicating the code used in the existing setup stages.

@joshmoore joshmoore self-assigned this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants