Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix realpath check in RdfImporter #1200

Closed
zerocrates opened this issue Jan 23, 2018 · 0 comments
Closed

Fix realpath check in RdfImporter #1200

zerocrates opened this issue Jan 23, 2018 · 0 comments
Milestone

Comments

@zerocrates
Copy link
Member

It's currently causing issues on Windows because we use mixed slashes (PHP doesn't care, but realpath corrects them), see https://forum.omeka.org/t/errors-after-installing-omeka-s/3088/6

It's also possible it would cause issues with legitimate symlinks. The idea here with these "realpath" type checks usually is to ensure that there's no attempt to give, for example, a filename within a directory that attempts to traverse down the tree and reference something elsewhere on the filesystem. Here we're not attempting to be restrictive in that way, and the Importer's facility for reading a file at a given path isn't directly exposed anywhere, so I don't think the check here really is providing any value.

@zerocrates zerocrates added this to the March 5 milestone Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant