Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item w/ metadata does not use captions #1483

Closed
kimisgold opened this issue Dec 19, 2019 · 2 comments
Closed

Item w/ metadata does not use captions #1483

kimisgold opened this issue Dec 19, 2019 · 2 comments
Labels

Comments

@kimisgold
Copy link
Member

The "Item with Metadata" block provides caption fields for its attachments because it's using the standard attachment sidebar form. However, its partial does not use values from that field. We should either eliminate that caption field or figure out the best use of the caption within the block's partial. I lean towards the former because the purpose of the block seems to be replicating the item show view within a page, and there's no caption equivalent in the original view.

@zerocrates
Copy link
Member

zerocrates commented Jan 15, 2020

Consensus is remove/hide the caption input here.

@zerocrates
Copy link
Member

This looks to be a simpler problem than expected, actually: the block doesn't use the selected media, either, so we should be able to just use the pre-existing functionality for putting the chooser in "item only" mode, which will skip the caption and media selection panel completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants