Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple IIIF image viewers on a single page broken in 4.0 #1993

Closed
zerocrates opened this issue Jan 30, 2023 · 0 comments
Closed

Multiple IIIF image viewers on a single page broken in 4.0 #1993

zerocrates opened this issue Jan 30, 2023 · 0 comments
Assignees

Comments

@zerocrates
Copy link
Member

See https://forum.omeka.org/t/seadragon-redeclaration-error/16594

The script for loading OpenSeadragon was changed to use const, but in the global scope, so loading that script more than once results in the const being declared again and reassigned, which is an error.

We could change the declarations here to var/let to just avoid the specific issue, introduce a surrounding scope so the consts don't conflict, or rewrite it so it's a function that's loaded as an external script that's either just called by each viewer, or is triggered on all viewers on load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants