-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0: Title printing broken on browse pages #1996
Comments
Ultimately the trick here is that we don't have a simple way of having the linkPretty markup but just changing the text part. We can either look at being able to pass in to linkPretty to override the text, or make it easier to get at the same linkPretty markup if we want to construct a link with linkRaw manually (a partial?). We can make the fix and just manually use the correct matching markup, and may go that way in a bugfix release only, but for future maintainability we'll want to have that markup pattern coming from a common place. |
The code used for choosing the title to display based on local for public views is broken in a few ways on the public side.
The lang issue is more subtle and was pre-existing, but the problem with the usage of linkPretty breaks both the language selection and browse heading property selection, and is a 4.0 regression.
The text was updated successfully, but these errors were encountered: