Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize the item's description in browse view. #1492

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

fukuchi
Copy link
Contributor

@fukuchi fukuchi commented Jan 4, 2020

When you use the default theme and see the item's properties, the texts are sanitized by escapeHtml().
Screenshot from 2020-01-04 14-21-02

But in the list view of the items, the text of the description property is not sanitized.
Screenshot from 2020-01-04 14-20-04

This patch simply solves the problem by encapsulating the text with $escape().
Screenshot from 2020-01-04 14-20-43

@zerocrates
Copy link
Member

Thanks for your contribution.

@zerocrates zerocrates merged commit f1cf1cf into omeka:develop Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants