Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with league/oauth2-client 2.4 #6

Closed
codemonkey1988 opened this issue Nov 22, 2018 · 2 comments
Closed

Conflict with league/oauth2-client 2.4 #6

codemonkey1988 opened this issue Nov 22, 2018 · 2 comments
Assignees

Comments

@codemonkey1988
Copy link
Contributor

codemonkey1988 commented Nov 22, 2018

There is a new release of league/oauth2-client that brings a breaking change for this package.

The method League\OAuth2\Client\Provider\AbstractProvider::getResourceOwnerDetailsUrl was updated by changing its argument type from League\OAuth2\Client\Token\AccessToken to League\OAuth2\Client\Token\AccessTokenInterface.
This breaks the class inheritance for Omines\OAuth2\Client\Provider\GitLab::getResourceOwnerDetailsUrl

@codemonkey1988
Copy link
Contributor Author

There is a new release of league/oauth2-client package (2.4.1) that fixes this problem.
See thephpleague/oauth2-client@bb12ba5#diff-58d25fe37b0dacc76bd6b7373506e480

So there is only a conflict with version 2.4.0
Maybe a conflict entry in composer.json may be a good and easy solution here.

@curry684
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants