Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in JSDoc comments from DefinitelyTyped pull request #136

Closed
JoshuaKGoldberg opened this issue May 18, 2023 · 0 comments · Fixed by #203
Closed

Add in JSDoc comments from DefinitelyTyped pull request #136

JoshuaKGoldberg opened this issue May 18, 2023 · 0 comments · Fixed by #203
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Collaborator

DefinitelyTyped/DefinitelyTyped#65502 adds a lot of /** ... */ JSDoc comments to code, based on this repo's README.md. I ended up not including those comments in #128 so as to not make too many changes to code.

It'd be great to have someone add those JSDoc comments to this repository! Leaving this issue open as a good first issue in case someone wants to come along. 😁

_(also, note that that PR isn't reviewed as of this issue being filed - those JSDoc comments might have mistakes/typos...)
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! good first issue Good for newcomers, please hop on! area: tooling Managing the repository's maintenance and removed area: tooling Managing the repository's maintenance labels May 18, 2023
@ikelax ikelax mentioned this issue Sep 30, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add JSDoc comments from DefinitelyTyped pull request ikelax/node-emoji
1 participant
@JoshuaKGoldberg