Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move away from safe.contract(...) and use interface.I...(...) instead #5

Open
gosuto-inzasheru opened this issue Dec 28, 2021 · 0 comments

Comments

@gosuto-inzasheru
Copy link
Contributor

currently almost all contracts are initialised using self.safe.contract(...). this creates a dependency on etherscan or another explorer, and can become incorrect when the local abi db lags behind the abi of an upgradable proxy (see eth-brownie/brownie#1314).

instead, proper use of brownie's interfaces folder should be implemented. this redirects the dependency to the interfaces folder, for which the source is included in the repo and lets itself be easily adjusted. this also guarantees uniform underlying abis for all users, independent of their local brownie db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant